-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Localize DateTimePicker Component #11938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@nosolosw and @jasmussen would you mind looking to see if the capitalization rules are correct in Español and Dansk? It's correct for English but I'm seeing lower-case where I'm not expecting it. To test, check out the branch, set your language in wp-admin, then open the "Publish" date picker on a post. All the changes are in PHP so no rebuild is needed. |
|
For core merge we might do something similar as with |
|
I've checked and different apps have different ways to localize dates in Spanish: I get lowercase months in some and uppercase in others. In case it's helpful, I've checked the Spanish translations in GlotPress (WordPress project) and they are consistent with what I saw in the settings page/calendar (lowercase for weekdays and whole months, uppercase for 3-letter months): |
youknowriad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does work for me in French and Arabic. I'd have preferred a fix in the data picker component instead of relying on moment being available as a global. That said it can be refactored later.
Would you mind rebasing and merging?
21e6166 to
a947dbc
Compare
|
This will be backported in Core during the packages updates. |
|
Just to drag some attention to this issue that's affecting users with the dashboard language being set to other than English: |






Description
wp-date is deprecating its moment method, so we need to localize
Closes #4533 and #9109
How has this been tested?
Screenshots
Localized month and day (Esperanto

)
Week starts on Wednesday:

Types of changes
Checklist: