Skip to content

Conversation

@mtias
Copy link
Member

@mtias mtias commented Nov 19, 2018

Small copy change to improve clarity of this mode:

image

@mtias mtias added the [Type] Copy Issues or PRs that need copy editing assistance label Nov 19, 2018
@mtias mtias added this to the 4.5 milestone Nov 19, 2018
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM . 👍

@mtias mtias merged commit 25b834e into master Nov 19, 2018
@mtias mtias deleted the update/top-toolbar-name branch November 19, 2018 19:41
@afercia
Copy link
Contributor

afercia commented Nov 21, 2018

Just noting "Unified Toolbar" was clearer to me. Not sure where this change has been discussed and what the argumentation is.

@0aveRyan
Copy link
Contributor

This change should have been discussed, it affects docs work already done and added confusion to this morning's #core-editor meeting 😕Also, Top Toolbar adds some potential confusion with the wp admin bar for users reading docs.

@earnjam
Copy link
Contributor

earnjam commented Nov 29, 2018

@mtias Can you clarify whether there was any discussion about making this change? I never saw any examples of reports of confusion about the term "Unified Toolbar", so this comes as a surprise to me. I wasn't aware it was changed until it came up in the #core-editor chat yesterday. I asked about it there shortly after, but no one responded.

FWIW, I actually think this is a step backward in clarity. To me, "Top Toolbar" is more confusing than "Unified Toolbar". There is always a top toolbar present whether this mode is on or not. When active, this mode “unifies” the two types of toolbars (editor toolbar and block toolbar) into one. Even the description reads like an explanation of the word “unified”. Access all block and document tools in a single place (That description is also inaccurate because not all block and document tools are there...many are in the sidebar. But that's for a different discussion)

I realize this is bikeshedding, but the bigger concern I have is more in why we would change the name of a major piece of functionality the day before the RC is released without any discussions or even an issue dedicated to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Copy Issues or PRs that need copy editing assistance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants