Fix issue with dragondrop in columns #12159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The selector for enabling pointer events was a little too deep, which meant that dragondrop broke. This fixes it, but the columns block retains the simplicity of not allowing you to click/select columns still.
jorgefilipecosta
approved these changes
Nov 21, 2018
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
Fixes the issue for me. It was impossible to use drag & drop inside columns and with this change it is possible 👍
Contributor
Author
|
Cool, thank you! I'm leaving this unmerged for, but milestoned so we'll get it in. |
Contributor
Author
|
4.5.1 is out, so merging! |
designsimply
added
[Feature] Drag and Drop
This was referenced Nov 23, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selector for enabling pointer events was a little too deep, which meant that dragondrop broke. This fixes it, but the columns block retains the simplicity of not allowing you to click/select columns still.