Paragraph: clear dropcap height so hover area shown correctly #12177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the dropcap letter is floated, the height isn’t taken into account, causing the block’s hover area to be incorrect. Clear the float so the height is applied.
youknowriad
reviewed
Nov 26, 2018
| font-style: normal; | ||
| } | ||
|
|
||
| &.has-drop-cap::after { |
Contributor
There was a problem hiding this comment.
Should we apply this only when the RichText is focused? The dropcap is not shown when the block is focused.
Right now, if you type in a block with DropCap you can see that it's height is not the regular height because of this style.
Contributor
Author
There was a problem hiding this comment.
If you mean apply only when not focussed, then yes I missed that, and added!
If you do mean focussed then I'm not sure - can you add a screenshot?
youknowriad
removed
the
[Status] In Progress
youknowriad
pushed a commit
that referenced
this pull request
Jan 3, 2019
* Paragraph: clear dropcap height so hover area shown correctly Because the dropcap letter is floated, the height isn’t taken into account, causing the block’s hover area to be incorrect. Clear the float so the height is applied. * Restrict dropcap clearer to only focussed block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short paragraph with a dropcap shows a hover area that is too small:
This is because the dropcap letter is floated and the height isn’t taken into account, causing the block’s hover area to be incorrect. A paragraph that spans multiple lines won't exhibit this problem as the height is provided by the rest of the text.
This PR clears the dropcap so the height is applied.
Fixes problem in #12172
Fixes #12177
How has this been tested?
Checklist: