Skip to content

Conversation

@jorgefilipecosta
Copy link
Member

Description

Blocks that rely on InnerBlocks have some problems if the user uses the HTML edit function of the block the editor may crash.
To solve that on the columns block HTML edit was disabled, this PR applies the same solution to the Media & Text block.

Fixes:#11884

How has this been tested?

I added a media text block, I added content in it, I went to the block "More Options" menu and I verified "Edit as HTML option is not available.

@jorgefilipecosta jorgefilipecosta added this to the 4.6 milestone Nov 21, 2018
@jorgefilipecosta jorgefilipecosta added the [Type] Bug An existing feature does not function as intended label Nov 21, 2018
@jorgefilipecosta jorgefilipecosta requested a review from a team November 21, 2018 17:47
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. 👍

@jorgefilipecosta jorgefilipecosta merged commit c9fad3b into master Nov 21, 2018
@jorgefilipecosta jorgefilipecosta deleted the fix/disable-html-edit-media-text branch November 21, 2018 18:29
@mtias mtias added the [Block] Media & Text Affects the Media & Text Block label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Media & Text Affects the Media & Text Block [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants