Rename concatChildren() argument from childrens to childrenArguments #1232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Jun 19, 2017
element/index.js
Outdated
| * @param {...?Object} childrens Set of children to concatenate | ||
| * @return {Array} The concatenated value | ||
| * @param {...?Object} childrenArguments Array of children arguments (array of arrays/strings/objects) to concatenate | ||
| * @return {Array} The concatenated value |
Contributor
There was a problem hiding this comment.
I diff the diff here should be spaces and not tabs, that way the text would be aligned?
youknowriad
approved these changes
Jun 20, 2017
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Thanks for the quick fix 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a really small naming change that fixes #915.