Fix issue 1197 #1238
Closed
Fix issue 1197 #1238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix "excerpt" word typo on components/dashicon/index.js
Contributor
|
Hi @iamgabrielma, Thank you for the fix!! I think this needs to be done in the dashicon repository as well. The file that is edited is being generated from there. I think all you need to do is change the filename |
iamgabrielma
added a commit
to iamgabrielma/dashicons
that referenced
this pull request
Jun 18, 2017
Fixes typo. Related to WordPress/gutenberg#1238
Contributor
Author
|
Thanks @BE-Webdesign , that definitely makes sense. I think should be alright now |
Contributor
|
Closing this one because there's an upstream PR now! Thanks @iamgabrielma |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "excerpt" word typo on components/dashicon/index.js
Fixes #1197