Skip to content

Skip: Adding inline tokens end 2 end test. #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 1 commit into from
Nov 30, 2018
Merged

Skip: Adding inline tokens end 2 end test. #12464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/specs/adding-inline-tokens.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ describe( 'adding inline tokens', () => {
await newPost();
} );

it( 'should insert inline image', async () => {
Copy link
Contributor

@youknowriad youknowriad Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just .skip it for the moment?

Copy link
Member Author

@jorgefilipecosta jorgefilipecosta Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that a better option, the code was updated.

Copy link
Contributor

@youknowriad youknowriad Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ntwb Looks like it's a permissions issue (the upload is failing), I don't know if you have any idea why it started happening suddenly.

For now I'm going to approve to unblock the other PRs.

Copy link
Member

@gziolo gziolo Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an explanation why it was skipped? We have already 3 skipped tests which we never unskipped and they are already invalid even though the issues were already fixed.

it.skip( 'should insert inline image', async () => {
// Create a paragraph.
await clickBlockAppender();
await page.keyboard.type( 'a ' );
Expand Down