RichText: Reuse document in createElement

[ellatrix]

Description

This one is similar to #12402: we should reuse the same document in createElement calls. I wonder if we can use the same function in both places. Note that I had to move the old function to the test as it needs to be able to have two references.

Cc @aduth.

How has this been tested?

Screenshots

Types of changes

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code follows the accessibility standards.
• My code has proper inline documentation.

[aduth]

Note that I had to move the old function to the test as it needs to be able to have two references.

This is maybe a bit concerning in how we've already encountered legitimate need for holding the reference? I suppose this is all still internal to rich-text

Could the test maybe be updated to .cloneNode the value returned for each? It would be preferable if the test weren't running a custom reimplementation.

[aduth]

I wonder if we can use the same function in both places.

Would it be as simple as changing createEmpty (to-dom.js) to:

const createEmpty = () => createElement( document, '' );

?

[ellatrix]

Let's work on your PR.

[ellatrix]

This is maybe a bit concerning in how we've already encountered legitimate need for holding the reference? I suppose this is all still internal to rich-text

Yeah, I think it's fine. It's all internal.