Skip to content

Conversation

@afercia
Copy link
Contributor

@afercia afercia commented Dec 2, 2018

Description

This PR seeks to fix invalid HTML and invalid ARIA properties in the RichText component by removing the aria-expanded attribute. For more details, please see the related issue.

Fixes #12523

@afercia afercia requested review from talldan and tofumatt December 2, 2018 15:48
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more-red-than-green

Looks good, thanks! 👍

@tofumatt tofumatt added this to the 4.7 milestone Dec 3, 2018
@tofumatt tofumatt merged commit 652a662 into master Dec 3, 2018
@tofumatt tofumatt deleted the update/richtext-remove-aria-expanded branch December 3, 2018 16:35
@mtias mtias added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Code Quality Issues or PRs that relate to code quality labels Dec 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the aria-expanded attribute from RichText

4 participants