Merge similar strings #12540
Merged
Merge similar strings #12540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
approved these changes
Dec 3, 2018
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #10838, speak messages were changed to match Classic Editor. However, they do not match since messages in Classic Editor end with full stop (see). Third message, that is introduced here, uses full stop (
Link edited.).We should match behaviour in Classic Editor, or change both messages in Classic Editor and message that is new here.