Handbook: drastically improve I18N docs #12576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Enhancement
ocean90
requested changes
Dec 4, 2018
Co-Authored-By: swissspidy <[email protected]>
chrisvanpatten
approved these changes
Dec 4, 2018
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
Overall great, one thing I noticed was it switches from i18n and I18n (upper vs lowercase) on occasion and somewhat randomly. Would prefer, if possible, to standardize on one or the other (possibly only using capital I at the start of sentences or where title case is appropriate, e.g. headers. But this is great and makes sense to land sooner rather than later :)
Co-Authored-By: swissspidy <[email protected]>
ocean90
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some many things wrong with the internationalization.md document, I don't even know where to start.
What this PR does:
_doing_it_wrong()wp_set_script_translations()function.Related: #12502