Tests: Enabled popular plugins on Travis when running e2e test suite #12578
Conversation
gziolo
added
[Status] In Progress
gziolo
requested review from
gwwar,
notnownikki,
ntwb,
omarreiss,
pento and
tofumatt
gziolo
force-pushed
the
add/popular-plugins-e2e
branch
from
fc1e95a to
8c006bc
Compare
|
Thanks for doing this @gziolo! |
|
@jdevalk thinking about it a bit more after a few constructive chats. We could even go one step further and add some short tests for each plugin maintained by plugin authors which could contain some verifications for integration with Gutenberg they feel are the most important for them. |
|
We already have some running. @atimmer @moorscode can you discuss with Daria and select a few tests? |
|
Unrelate to this PR, but we could limit this: to create only |
|
I think the latest attempt fixed the issue with permissions but I see some tests failing. I hope it's a temporary thing. Kudos to @jorgefilipecosta for sharing the workaround 👏 |
|
The failing tests here don't seem temporary (I've restarted Travis a few times) and several are failing locally for me as well. They don't seem related at all though. 🤷♂️ |
jorgefilipecosta
force-pushed
the
add/popular-plugins-e2e
branch
2 times, most recently
from
2d93834 to
4edbcfd
Compare
| } ) | ||
| .then( () => store.dispatch( metaBoxUpdatesSuccess() ) ); | ||
| .then( () => store.dispatch( metaBoxUpdatesSuccess() ) ) | ||
| .catch( noop ); |
There was a problem hiding this comment.
Why does this happen/should we at least log an error here?
jorgefilipecosta
force-pushed
the
add/popular-plugins-e2e
branch
2 times, most recently
from
473dd0b to
03da3f5
Compare
|
@jorgefilipecosta what is the current status of this PR? Is the test failure for the preview feature a legitimate one? |
|
I re-ran the failing test a few times. The preview tests fails intermittently at different points, but the links test seems to be consistently failing. |
…t having a catch caused an end to end test to fail.
gziolo
force-pushed
the
add/popular-plugins-e2e
branch
from
03da3f5 to
693630a
Compare
It turns out that with Yoast SEO enabled, some e2e tests fail. It would nice if someone could help investigate. I'm trying with 4 plugins at the moment:
|
|
b2d8028 - trying without AMP as either it or WPForms breaks one test suite. |
|
Both AMP and Yoast SEO plugins need to be further investigated. Let's proceed with those which work out of the box and work the rest in separate PRs. |
tofumatt
left a comment
tofumatt
left a comment
There was a problem hiding this comment.
It might be best to even keep the plugin install instructions there but comment them out and add TODOs/issues to follow-up with them, but yeah this looks good and is at least a start. I say 
|
Yes, I will open a follow-up issue with a diff how to enable them. |
|
I created a follow-up issue: #13038. |
…12578) * Tests: Enabled popular plugins on Travis when running e2e test suite * Try running WP-CLI with a different user * Tweak if statement * Add back chmod dance on plugins related folders * Create upgrade folder * Add a temporary noop catch when api fetch for meta box save fails. Not having a catch caused an end to end test to fail. * Fix: clickBelow logic clicked on the meta boxes when a big meta box was open. * Make todo LOUD ;-) * Remove obsolete lines after rebasing with master * Let's try without AFC * Trying without Yoast SEO this time * Revert changes for the test * Enable 2 more plugins * Try without AMP
…12578) * Tests: Enabled popular plugins on Travis when running e2e test suite * Try running WP-CLI with a different user * Tweak if statement * Add back chmod dance on plugins related folders * Create upgrade folder * Add a temporary noop catch when api fetch for meta box save fails. Not having a catch caused an end to end test to fail. * Fix: clickBelow logic clicked on the meta boxes when a big meta box was open. * Make todo LOUD ;-) * Remove obsolete lines after rebasing with master * Let's try without AFC * Trying without Yoast SEO this time * Revert changes for the test * Enable 2 more plugins * Try without AMP
Description
It's a proof of concept. This needs more love ❤️
The idea is to enable a few popular plugins which integrate with Gutenberg to ensure they don't break with the changes that we are going to be introducing in the future.
For starts, this PR enables the following plugins listed at https://wordpress.org/plugins/browse/blocks/:
Yoast SEOAMPWe might want to add more of them in the future.
Implementation details
My shell skills aren't great so I would appreciate some help with polishing what I proposed 🙇
In particular, the way I solved the issue with file permissions to unblock plugins' installation is very hacky. By the way, it probably could be also the way to solve the issue we had last week with uploading inline images.