Skip to content

Grammatical mistakes & Missing spaces #12643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gziolo merged 3 commits into from
Dec 14, 2018
Merged

Grammatical mistakes & Missing spaces #12643

gziolo merged 3 commits into from
Dec 14, 2018

Conversation

@faisal-alvi
Copy link
Contributor

@faisal-alvi faisal-alvi commented Dec 6, 2018

Description

Fixing grammatical mistakes & adding the required space between 2 sentences.

How has this been tested?

Please visit this page. You can see the reported mistakes on the page.

Types of changes

Added 2 spaces between 2 sentences.

@faisal-alvi
Grammatical mistakes & Missing spaces
5dc366f 
Fixing grammatical mistakes & adding the required space between 2 lines.
@Soean Soean added the [Type] Copy Issues or PRs that need copy editing assistance label Dec 6, 2018
chrisvanpatten
chrisvanpatten suggested changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches on the missing spaces! The grammar change (providing vs. provide) was actually more correct the first time I think so I suggested reverting that.

Thanks for the contribution!

@chrisvanpatten chrisvanpatten added [Type] Developer Documentation Documentation for developers and removed [Type] Copy Issues or PRs that need copy editing assistance labels Dec 6, 2018
@faisal-alvi
Copy link
Contributor Author

faisal-alvi commented Dec 7, 2018

Thank you for the suggestions @chrisvanpatten Your all suggestions are 100% correct so applied! :)

@ntwb
Copy link
Member

ntwb commented Dec 7, 2018

The comma in the first change should also be kept

@faisal-alvi
Copy link
Contributor Author

faisal-alvi commented Dec 7, 2018 •
edited
Loading

@ntwb As per https://app.grammarly.com/ the comma should not be there, that is why I requested for that. However, we can keep it if it does not matter a lot.

@ntwb
Copy link
Member

ntwb commented Dec 10, 2018

Fair enough, I thought it should be kept, removing also is fine if that's the case

@faisal-alvi
Copy link
Contributor Author

faisal-alvi commented Dec 10, 2018

@chrisvanpatten can you please update milestone for this PR?

chrisvanpatten
chrisvanpatten approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@chrisvanpatten chrisvanpatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, then we can approve and merge!

@gziolo gziolo added this to the 4.8 milestone Dec 14, 2018
@gziolo
Copy link
Member

gziolo commented Dec 14, 2018

Thank you for contribution 👍

@gziolo gziolo merged commit c7afa34 into WordPress:master Dec 14, 2018
@gziolo gziolo modified the milestones: 4.8, Documentation & Handbook Dec 14, 2018
youknowriad pushed a commit that referenced this pull request Jan 9, 2019
@faisal-alvi @youknowriad
Grammatical mistakes & Missing spaces (#12643)
97af827 
* Grammatical mistakes & Missing spaces

Fixing grammatical mistakes & adding the required space between 2 lines.

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: faisal-alvi <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: faisal-alvi <[email protected]>
youknowriad pushed a commit that referenced this pull request Jan 9, 2019
@faisal-alvi @youknowriad
Grammatical mistakes & Missing spaces (#12643)
399b88f 
* Grammatical mistakes & Missing spaces

Fixing grammatical mistakes & adding the required space between 2 lines.

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: faisal-alvi <[email protected]>

* Update docs/designers-developers/developers/filters/block-filters.md

Co-Authored-By: faisal-alvi <[email protected]>
@faisal-alvi faisal-alvi deleted the patch-1 branch January 26, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntwb ntwb ntwb approved these changes

+1 more reviewer

@chrisvanpatten chrisvanpatten chrisvanpatten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Milestone

Documentation & Handbook

Development

Successfully merging this pull request may close these issues.

5 participants

@faisal-alvi @ntwb @gziolo @chrisvanpatten @Soean