Add a line to PR template for developer documentation #12822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Developer documentation is critical for making a platform extendable, developers need to know the proper way to extend a feature, or in a sense that does may not even exist.
chrisvanpatten
suggested changes
Dec 12, 2018
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
Love this idea. It's a nice subtle nudge. (Why didn't I think of this?!)
Co-Authored-By: mkaz <[email protected]>
chrisvanpatten
approved these changes
Dec 12, 2018
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
LGTM; hoping to get a maintainer ✅ as well.
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
* Add a line to PR template for developer documentation Developer documentation is critical for making a platform extendable, developers need to know the proper way to extend a feature, or in a sense that does may not even exist. * Update .github/PULL_REQUEST_TEMPLATE.md Co-Authored-By: mkaz <[email protected]>
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
* Add a line to PR template for developer documentation Developer documentation is critical for making a platform extendable, developers need to know the proper way to extend a feature, or in a sense that does may not even exist. * Update .github/PULL_REQUEST_TEMPLATE.md Co-Authored-By: mkaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A meta change that applies only to Github repo, adding a line to the PR template around developer documentation.
Developer documentation is critical for making a platform extendable, developers need to know the proper way to extend a feature, or in a sense that does may not even exist.
We discussed the importance of documentation in #docs Slack channel, and thought updating PR template is one way to call out to developers to keep it in mind.