Update recommended config provided for lint-js script #12845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
commented
Dec 13, 2018
gziolo
force-pushed
the
update/lint-js-config
branch
from
c09ffc4 to
cc6ce31
Compare
ntwb
reviewed
Dec 14, 2018
gziolo
changed the title
ntwb
approved these changes
Dec 14, 2018
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
* Update default config provided for lint-js script * Update packages/scripts/CHANGELOG.md * Clarify usage of recommended configs in docs
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
* Update default config provided for lint-js script * Update packages/scripts/CHANGELOG.md * Clarify usage of recommended configs in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With #12763 we introduced
@wordpress/eslint-pluginpackage which offers the recommended config for WordPress development. This PR updateswp-scripts lint-jsscript to use this config as a default when there is no config provided in the project.How has this been tested?
npm run lint-jsin the project` - it should work as before../node_modules/.bin/wp-scripts lint-js .- it will produce tons of errors because the default config doesn't support Jest tests or Puppeteer API by default.To consider
Should we also include support for Jest and Puppeteer in the recommended config? The thing is that we offer them in other scripts exposed (or planned to be exposed) as part of
@wordpress/scriptspackage.