Fixed incorrect example code #12906
Merged
Fixed incorrect example code #12906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
Looks okay to me but I'd like someone more familiar with the data module to review!
chrisvanpatten
added
[Type] Developer Documentation
aduth
approved these changes
Dec 18, 2018
Member
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Thanks for this.
I conferred with @youknowriad and looked over #5219 . The omission of state is intentional for resolvers, so these adjustments are correct.
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
youknowriad
pushed a commit
that referenced
this pull request
Jan 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I fixed what I believe were some typos in the
registerStoreexample for the data package. When I tried the function the way it is in the documentation, thestateargument in thegetPriceresolver has the value expected to be defined in theitemargument and theitemargument is undefined.It looks like maybe the function changed at some point and the documentation wasn't updated.