Fix: Only 10 taxonomies with 'show_in_rest' available in the editor's sidebar #12971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
[Type] Bug
swissspidy
approved these changes
Dec 18, 2018
Contributor
|
Would you mind rebasing to retrigger the tests? |
jorgefilipecosta
force-pushed
the
fix/only-ten-taxonomies-with-show_in_rest-available-in-the-editors-sidebar
branch
from
dda7890 to
220c280
Compare
Member
Author
|
The tests passed, I'm going to merge this PR. |
jorgefilipecosta
deleted the
fix/only-ten-taxonomies-with-show_in_rest-available-in-the-editors-sidebar
branch
|
@jorgefilipecosta Props zu @realworldev for the code snippet for testing. |
Member
Author
|
Sorry @realworldev, I missed your nickname. The description was corrected. Thank you for the code snippet it was very useful 👍 |
youknowriad
pushed a commit
that referenced
this pull request
Jan 3, 2019
… sidebar (#12971) Fixes: #12649 Props to @danielbachhuber and @VadymPogorelov for the debugging. ## Description In the taxomies data request present in the PostTaxonomies component we had a per-page config of -1 to request all the taxonomies. https://github.com/WordPress/gutenberg/blob/master/packages/editor/src/components/post-taxonomies/index.js#L41 But on the checking component that verifies the post type relationship with the taxonomies we did set the per page config of -1 so only ten taxonomies were being requested. ## How has this been tested? I added the following code snippet for testing purposes: ``` add_action( 'init', function() { for ( $j=0; $j < 12; $j++ ) { register_post_type( 'cpt_' . $j, array( 'label' => 'cpt ' . $j, 'show_in_rest' => true, 'public' => true, ) ); for ( $i=0; $i < 4; $i++ ) { register_taxonomy( 'taxonomy_' . $j . '_' . $i, 'cpt_' . $j, array( 'label' => 'taxonomy ' . $j . ' ' .$i, 'show_in_rest' => true, ) ); } } }); ``` I verified that even in CPT greater than 2 the taxnomies appear as expected, on master that's not the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12649
Props to @danielbachhuber, @VadymPogorelov, and @realworldev for the debugging and testing code.
Description
In the taxonomies data request present in the PostTaxonomies component we had a per-page config of -1 to request all the taxonomies.
https://github.com/WordPress/gutenberg/blob/master/packages/editor/src/components/post-taxonomies/index.js#L41
But on the checking component that verifies the post type relationship with the taxonomies we did set the per page config of -1 so only ten taxonomies were being requested.
How has this been tested?
I added the following code snippet for testing purposes:
I verified that even in CPT greater than 2 the taxnomies appear as expected, on master that's not the case.