Fix alignment of property assignments in the __construct() function

[desrosj]

When grunt build is run in WordPress core, the parser is copied to the appropriate place in the core code base. But, because these lines are not aligned correctly, the wp-includes/class-wp-block-parser.php file always shows changes.

This fix will prevent that from happening.

See the Slack discussion for more information.

[youknowriad]

Do you know why this wasn't caught by the phpcs config in Gutenberg? should we update it?

[desrosj]

🤔 Good question. Let me dig in a bit. I am not familiar with the plugin's ruleset.

[earnjam]

Hmm, now that I look, there are a number of PHPCS issues in this file. Wonder if it's running against it at all.

[desrosj]

There is <exclude-pattern>./lib/parser.php</exclude-pattern> in the PHPCS file, but I don't think this is excluding this specific file.

I think that the file is just not being processed from lack of inclusion rather than exclusion. Replacing all the <file></file> tags and replacing them with just <file>.</file> (all files) correctly formats this file, but also a handful of others (but all other files are e2e or phpunit test related).

If possible, I'd like to merge this change, and explore modifying the ruleset in a separate PR.

[earnjam]

Just an alignment fix 👍

[youknowriad]

Also would be good if we create a corresponding issue in the 5.0.3 milestone. That way we don't forget to include it in the next package release.

[earnjam]

So it looks like we aren't running PHPCS against any packages except block-library

from phpcs.xml.dist:

	<file>./bin</file>
	<file>./packages/block-library/src</file>
	<file>./lib</file>
	<exclude-pattern>./lib/parser.php</exclude-pattern>
	<file>./phpunit</file>
	<file>gutenberg.php</file>

Changing that to run against all packages kicks errors in the block-serialization-default-parser and block-serialization-spec-parser packages. How should we handle that @youknowriad? The former looks like it has a bunch of issues to be corrected.

[youknowriad]

Can we add the package the phpunit config and fix the issues? Is it too much work?

[gziolo]

Can we add the package the phpunit config and fix the issues? Is it too much work?

It's already tracked in #13002 which is assigned to 5.0.3 Milestone :)

[desrosj]

I believe that this did not make it in time for the package releases for 5.0.2, so moving this to the next milestone. If that is not true, feel free to move it back.

[youknowriad]

This will be 4.8 actually which is the current (closed scope) milestone.