Plugin: Deprecate gutenberg_add_gutenberg_post_state #13471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Gutenberg Plugin
aduth
force-pushed
the
remove/gutenberg-post-state
branch
from
3b8f5e8 to
1556bf2
Compare
jorgefilipecosta
approved these changes
Jan 28, 2019
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
LGTM 👍 The editor continues to work as before, the warning related to the containing Gutenberg blocks still appear if we try to open the post in the classic editor. I did not found any other usage of gutenberg_add_gutenberg_post_state.
Member
Author
For what it's worth, this will separately be removed as of #13442 . Kinda curious how you were able to load the classic editor in the first place 🤔 |
This was referenced Feb 4, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #11015
This pull request seeks to deprecate and remove logic from
gutenberg_add_gutenberg_post_state. This added the "Gutenberg" text on a post in the post listing screen.With 5.0 being released, this no longer really serves a purpose to distinguish posts.
Testing instructions:
Verify there is no "Gutenberg" label on posts in the post listing screen.