Don't do anything in RichTextInputEvent on native mobile #13929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hypest
added
the
Mobile App - i.e. Android or iOS
SergioEstevao
approved these changes
Feb 18, 2019
Contributor
SergioEstevao
left a comment
SergioEstevao
left a comment
There was a problem hiding this comment.
This is working fine on the mobile apps, but for some reason, we have a failed unit test.
Contributor
|
LGTM on Android device! |
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent work (#13833) on the RichText implementation has introduced the
RichTextInputEventcomponent but, that doesn't play well on native mobile since there is no real DOM available. This PR just "grounds" the component to just have it do nothing in the native mobile case.How has this been tested?
Use the gutenberg-mobile side PR: wordpress-mobile/gutenberg-mobile#612
Types of changes
Introduce a native mobile implementation of the
RichTextInputEventcomponent that does nothing.Checklist: