Skip to content

Add group block #13964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 52 commits into from
Apr 1, 2019
Merged

Add group block #13964

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
6aebbba
Add initial container block
talldan Feb 14, 2019
9ca4d46
Add background color controls to the container block
talldan Feb 14, 2019
e806dc1
Add `anchor` support to container block
talldan Feb 15, 2019
d90b595
Add option for editing container block padding
talldan Feb 18, 2019
aeb7739
Add padding with preset narrow and wide options
talldan Feb 18, 2019
d4a073e
Add padding toggle
talldan Feb 18, 2019
1c3382c
Ensure background color class name is set in block edit
talldan Feb 18, 2019
5c74f05
Switch padding option to disable padding instead of enabling
talldan Feb 20, 2019
e3bb63c
Set a default background color
talldan Feb 20, 2019
e4ff533
Add e2e test for adding container block
talldan Feb 20, 2019
2ad9ee4
Add e2e tests for the container block
talldan Feb 20, 2019
d31a55e
updated the default toggle text and behaviour for the container's pad…
draganescu Feb 20, 2019
dc253f9
removed the padding toogle and added default padding to the container…
draganescu Feb 22, 2019
b691d94
Remove container block margin when a background is set. Allows consec…
talldan Feb 25, 2019
36efeba
Adds keywords to aid in discoverability
getdave Mar 1, 2019
551f5e9
Removes default background
getdave Mar 13, 2019
6308812
Renames Block from Container to Section
getdave Mar 13, 2019
600e963
Utilise correct spacing variable for consistency
getdave Mar 14, 2019
99ea32f
Implement same padding rules as used in columns block for container b…
talldan Mar 12, 2019
3535363
Resolve block validation error when custom background color used. Cau…
talldan Mar 15, 2019
6123430
Feature flag the section block
talldan Mar 15, 2019
2ccfd83
Update e2e tests with renamed section block
talldan Mar 15, 2019
7acf0bf
Add fixture for section block for full content test
talldan Mar 15, 2019
f1dc3a9
Adds alignment for inner blocks that support alignment controls
getdave Mar 15, 2019
1cd84d1
Fixes width of wide Media text Block within full width Section Block
getdave Mar 19, 2019
ceebdbc
Removes Block default padding
getdave Mar 20, 2019
5eb9b7c
Fixes alignment layout within Seciton Blocks for all alignable Block …
getdave Mar 20, 2019
16716b9
Adds specificity required to only target immediate child Blocks of Se…
getdave Mar 21, 2019
4e0cb9c
Reintroduces padding on request
getdave Mar 21, 2019
473ab59
Adds fix to images as edge case
getdave Mar 21, 2019
a6af16a
Removes unwanted whitespace top/bottom of Block
getdave Mar 21, 2019
908a869
Fixes wide child Block alignment within full width Section
getdave Mar 22, 2019
2ba30a9
Fixes full width image alignment within full width Section.
getdave Mar 22, 2019
89d9939
Removes usage of Block name as Sass variable
getdave Mar 22, 2019
fd8f45d
Updates hard coded spacing to variables
getdave Mar 22, 2019
0ca88ff
Fixes excessive Section Block padding on tiny screens
getdave Mar 22, 2019
1176f56
Updates to add padding only when background is added to Block
getdave Mar 25, 2019
45565e8
Fixes Block overlap between adjacent Blocks when no background applied
getdave Mar 25, 2019
ad49f6d
Restores fix for Columns Block to ensure move/drag handles visible in…
getdave Mar 26, 2019
8e383bb
Fixes 1px of overflow on full width blocks
getdave Mar 26, 2019
6648523
Applies another fix to 1px overflow issue
getdave Mar 28, 2019
a7c6d36
Makes Block reusable
getdave Mar 28, 2019
e3f30b1
Removes feature flag
getdave Mar 28, 2019
49353da
Fixes overflow issues
getdave Mar 28, 2019
91a147d
Fix width of context toolbar causing overflow-x
getdave Mar 28, 2019
1277032
Updates Section padding values to match paragraph Block
getdave Mar 29, 2019
f890830
Fixes failing Block transforms e2e test
getdave Mar 29, 2019
225c504
Fixes Block overflowing off screen on <600px full width Section
getdave Mar 29, 2019
6417586
Fix to make full width children full width when background padding added
getdave Mar 29, 2019
fcee560
Remove superflous Section keyword
getdave Mar 29, 2019
2e19d94
Removes superflous resuable setting
getdave Mar 29, 2019
0047415
Updates to use `block-editor` package and avoid proxy
getdave Apr 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Updates to use block-editor package and avoid proxy 
Resolves #13964 (comment)
  • Loading branch information
@getdave
getdave committed Apr 1, 2019
commit 004741573717dbf3a8c8b943dc32509d9e1a0b31
2 changes: 1 addition & 1 deletion packages/block-library/src/section/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
InnerBlocks,
PanelColorSettings,
withColors,
} from '@wordpress/editor';
} from '@wordpress/block-editor';

function SectionEdit( { className, setBackgroundColor, backgroundColor } ) {
const styles = {
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/section/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import classnames from 'classnames';
*/
import { Path, SVG } from '@wordpress/components';
import { __ } from '@wordpress/i18n';
import { InnerBlocks, getColorClassName } from '@wordpress/editor';
import { InnerBlocks, getColorClassName } from '@wordpress/block-editor';

/**
* Internal dependencies
Expand Down