RichText: introduce onEnterAtEnd #14143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Heya any update on this? I was about to report it and I noticed has been discussed and with the fix pending. :) |
Member
Author
|
@folletto I mislinked this PR. Do you know an existing issue that this PR would fix? |
Contributor
|
So it's not a fix for #14114? I noticed that bug today in the stable WordPress release and I was about to report it, but I noticed it was marked as "closed". |
Member
Author
Contributor
|
Ok so should be upcoming in the next WordPress release. Got it, thanks! |
Member
|
Is it similar to what I try to do in #16880? :) |
Member
Author
|
@gziolo I think it is! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14114.(Does not fix that issue.) Not sure if this is the right behaviour. Are there any other cases when a new paragraph should be created? What if the user presses enter in the middle? Then I think we should only insert a line break.How has this been tested?
Screenshots
Types of changes
Checklist: