Skip to content

HorizontalRule component for cross-platform separator block #14361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koke merged 10 commits into from
Apr 17, 2019
Merged

HorizontalRule component for cross-platform separator block #14361

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d632f74
Port separator block to mobile
koke Mar 9, 2019
7336885
Default style for Hr on native
koke Mar 9, 2019
dc7bab2
Rename Hr primitive to HorizontalRule
koke Apr 12, 2019
913bbe0
Improved prop handling on HorizontalRule
koke Apr 12, 2019
c106ea3
Merge branch 'master' into rnmobile/separator-block
koke Apr 17, 2019
8616d45
Fix HorizontalRule import after renaming
koke Apr 17, 2019
842c6be
Add HorizontalRule README
koke Apr 17, 2019
3b24f25
Add Usage section to HorizontalRule README
koke Apr 17, 2019
48ab935
Add Changelog entry for HorizontalRule
koke Apr 17, 2019
ad913ef
Expand definition of HorizontalRule from MDN documentation
gziolo Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Expand definition of HorizontalRule from MDN documentation 
Co-Authored-By: koke <jbernal@gmail.com>
  • Loading branch information
@gziolo @koke
gziolo and koke authored Apr 17, 2019
commit ad913ef354ef14d13a613ccb17ec122777b27647
2 changes: 1 addition & 1 deletion packages/components/src/primitives/horizontal-rule/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# HorizontalRule

A drop-in replacement for the hr element that works on the web and the mobile apps.
A drop-in replacement for the HTML [hr](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hr) element that works both on the web and in the mobile apps. It represents a thematic break between paragraph-level elements: for example, a change of scene in a story, or a shift of topic within a section.

## Usage

Expand Down