Fix: Regression: Template lock option is not taken into consideration #14390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
requested review from
aduth,
ajitbohra,
gziolo,
nerrad,
noisysocks,
ntwb,
talldan and
youknowriad
as code owners
…; Add: end to end tests;
jorgefilipecosta
force-pushed
the
fix/post-type-template-lock-option-does-not-work
branch
from
d70f0b1 to
7ac72b7
Compare
jorgefilipecosta
added
[Type] Bug
jorgefilipecosta
added
the
[Release] Do Not Punt
youknowriad
approved these changes
Mar 15, 2019
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Thanks for the fix and the tests 👍
jorgefilipecosta
deleted the
fix/post-type-template-lock-option-does-not-work
branch
This was referenced Mar 18, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
…; Add: end to end tests; (#14390)
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
…; Add: end to end tests; (#14390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression happened because the templateLock flag was missing as one of the block-editor settings to pick in packages/editor/src/components/provider/index.js.
End 2 end tests that catch this problem were added.
How has this been tested?
I checked that the end 2 end tests pass.
I reverted the changes in packages/editor/src/components/provider/index.js, and I verified some of the tests start failing.