Skip to content

Align Spinner circles in RTL locales #14418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowriad merged 1 commit into from
Mar 14, 2019
Merged

Align Spinner circles in RTL locales #14418

youknowriad merged 1 commit into from
Mar 14, 2019

Conversation

@Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Mar 13, 2019

Description

Fixes #14417.

Using a RTL locale, the Spinner circles were misaligned (see screenshots below).

We found this issue while working on adding RTL support to wc-admin: woocommerce/woocommerce-admin#1776

How has this been tested?

Verifying it renders correctly in the browser. It's a small CSS change, so it shouldn't affect other parts of the codebase.

Screenshots

Before:
spinner-before

After:
spinner-after

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@Aljullu Aljullu requested a review from chrisvanpatten as a code owner March 13, 2019 17:02
@Aljullu Aljullu mentioned this pull request Mar 13, 2019
Closed
18 tasks
@swissspidy swissspidy added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Mar 14, 2019
@youknowriad
Copy link
Contributor

youknowriad commented Mar 14, 2019

Thanks for the contribution :)

@youknowriad youknowriad merged commit 589a634 into WordPress:master Mar 14, 2019
@Aljullu Aljullu deleted the fix/rtl-spinner-misalignment branch March 14, 2019 12:46
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Mar 15, 2019
@youknowriad youknowriad added this to the 5.3 (Gutenberg) milestone Mar 15, 2019
This was referenced Mar 18, 2019
Merged
Merged
Closed
Closed
youknowriad pushed a commit that referenced this pull request Mar 20, 2019
@Aljullu @youknowriad
Align Spinner circles in RTL locales (#14418)
52f3fc1
youknowriad pushed a commit that referenced this pull request Mar 20, 2019
@Aljullu @youknowriad
Align Spinner circles in RTL locales (#14418)
f62fa36
@Aljullu Aljullu mentioned this pull request Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

Assignees

No one assigned

Labels

Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Bug An existing feature does not function as intended

Projects

None yet

Milestone

5.3 (Gutenberg)

Development

Successfully merging this pull request may close these issues.

Spinner misalignment in RTL locales

3 participants

@Aljullu @youknowriad @swissspidy