Raw handling: update strikethrough #14430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
requested review from
aduth,
gziolo,
noisysocks and
youknowriad
as code owners
ellatrix
added
the
Good First Review
kelin1003
approved these changes
Mar 14, 2019
jorgefilipecosta
approved these changes
Mar 14, 2019
Member
jorgefilipecosta
left a comment
jorgefilipecosta
left a comment
There was a problem hiding this comment.
LGTM 👍
I pasted <p>Hello <span style="text-decoration-line: line-through">World</span></p>on master and I got <p>Hello <del>World</del></p>, in this branch I got <p>Hello <s>World</s></p>. Would it be possible to add a test case covering this before the merge?
This was referenced Mar 20, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
youknowriad
pushed a commit
that referenced
this pull request
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split out from #14429.
Follow up to #14389.
Adds
sto the phrasing content schema for raw handling.How has this been tested?
Screenshots
Types of changes
Checklist: