Skip to content

Keep styling after spliting a block #14464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jackie6 wants to merge 7 commits into from
Closed

Keep styling after spliting a block #14464

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0e3c226
Keep styling after spliting a block
Jackie6 Mar 15, 2019
e4cc00a
Remove styling if before is void of content
Jackie6 Mar 16, 2019
ff40169
Avoid mutating the attributes of the current block
Jackie6 Mar 18, 2019
c383e0c
Add comma for keeping coding style
Jackie6 Mar 18, 2019
430fd88
Keep styling after press delete
Jackie6 Mar 28, 2019
695a528
Apply the attributes of blockB into blockA
Jackie6 Apr 2, 2019
79f37e9
Update the merge attributes method of paragraph block
Jackie6 Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply the attributes of blockB into blockA
  • Loading branch information
@Jackie6
Jackie6 committed Apr 2, 2019
commit 695a528d150e1d8096d36230a275211c8f3c1b86
3 changes: 2 additions & 1 deletion packages/block-editor/src/store/effects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,8 @@ export default {
{
...blockA,
attributes: {
...( blockA.attributes.content.length === 0 ? blockB.attributes : blockA.attributes ),
...blockA.attributes,
...blockB.attributes,
...updatedAttributes,
},
},
Expand Down