Exculde test files when rebuilding packages #14468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie6
requested review from
aduth,
ajitbohra,
gziolo,
nerrad,
ntwb and
youknowriad
as code owners
gziolo
added
[Type] Build Tooling
gziolo
approved these changes
Mar 18, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
It works great in my testing. Thanks for working on this PR.
Member
I see that this issue self-resolved. It was probably an issue with one of the used dependencies. |
Member
|
@Jackie6 congrats on your first merged code contribution 🎉 |
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #11799
How has this been tested?
Types of changes
Use regular expressions to exclude test files including .js files inside of tests or test folders and files with a suffix of .test or .spec (e.g. blocks.test.js) such webpack will not rebuild these files when watching some changes.
Checklist: