Skip to content

Blocks API: Improve validation after block gets filters applied #14529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gziolo merged 5 commits into from
Mar 28, 2019
Merged

Blocks API: Improve validation after block gets filters applied #14529

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a604566
Block API: Improve validation after block gets filters applied
gziolo Mar 20, 2019
f256782
Update CHANGELOG.md
gziolo Mar 25, 2019
6d5f272
Update CHANGELOG.md
gziolo Mar 28, 2019
c6cf802
Apply suggestions from code review
gziolo Mar 28, 2019
1bc41a8
Update CHANGELOG.md
gziolo Mar 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-Authored-By: gziolo <grzegorz@gziolo.pl>
  • Loading branch information
@gziolo
gziolo authored Mar 28, 2019
commit c6cf8023f719e0e3c3d7919ebe0ba8e2649b0720
2 changes: 1 addition & 1 deletion packages/blocks/src/api/registration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export function registerBlockType( name, settings ) {
settings = applyFilters( 'blocks.registerBlockType', settings, name );
if ( ! isPlainObject( settings ) ) {
console.error(
'Block settings need to remain a plain object after all "blocks.registerBlockType" filters are applied.'
'Block settings must be a valid object.'
);
return;
}
Expand Down
2 changes: 1 addition & 1 deletion packages/blocks/src/api/test/registration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ describe( 'blocks', () => {
return [ settings ];
} );
const block = registerBlockType( 'my-plugin/fancy-block-13', defaultBlockSettings );
expect( console ).toHaveErroredWith( 'Block settings need to remain a plain object after all "blocks.registerBlockType" filters are applied.' );
expect( console ).toHaveErroredWith( 'Block settings must be a valid object.' );
expect( block ).toBeUndefined();
} );
} );
Expand Down