Allow failures on php versions below 5.5 #14541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to https://core.trac.wordpress.org/changeset/44950
Contributor
|
What's the reasoning here, why not just remove all the jobs for php 5.5 and lower? |
Member
Author
|
Has the plugin dropped support for WP 5.1? Until that happens, it should still work on old php versions. |
Contributor
|
Good point @aaronjorbin Let's keep them for some time then. |
youknowriad
approved these changes
Mar 21, 2019
youknowriad
requested changes
Mar 21, 2019
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
I was too quick, why do we have two jobs for these versions now?
youknowriad
approved these changes
Mar 21, 2019
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Just read the description of the PR. Sorry for the back and forth.
gziolo
added
the
[Type] Automated Testing
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to https://core.trac.wordpress.org/changeset/44950
Based on the docs - https://docs.travis-ci.com/user/build-matrix/#rows-that-are-allowed-to-fail - The allow_failures entry needs to exactly match the jobs.