Update Blocks Tutorial to match Gutenberg Examples #14584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkaz
requested review from
ajitbohra,
chrisvanpatten,
gziolo,
notnownikki,
oandregal and
youknowriad
as code owners
chrisvanpatten
previously requested changes
Mar 22, 2019
Contributor
chrisvanpatten
left a comment
chrisvanpatten
left a comment
There was a problem hiding this comment.
Small tweak but otherwise great. I didn't vet the code too closely, FYI :)
...developers/developers/tutorials/block-tutorial/introducing-attributes-and-editable-fields.md
Show resolved
Hide resolved
...developers/developers/tutorials/block-tutorial/introducing-attributes-and-editable-fields.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: mkaz <[email protected]>
oandregal
reviewed
Mar 25, 2019
docs/designers-developers/developers/tutorials/block-tutorial/writing-your-first-block-type.md
Outdated
Show resolved
Hide resolved
oandregal
reviewed
Mar 25, 2019
...designers-developers/developers/tutorials/block-tutorial/applying-styles-with-stylesheets.md
Outdated
Show resolved
Hide resolved
oandregal
reviewed
Mar 25, 2019
...designers-developers/developers/tutorials/block-tutorial/applying-styles-with-stylesheets.md
Show resolved
Hide resolved
oandregal
reviewed
Mar 25, 2019
...designers-developers/developers/tutorials/block-tutorial/applying-styles-with-stylesheets.md
Show resolved
Hide resolved
…writing-your-first-block-type.md Co-Authored-By: mkaz <[email protected]>
Member
Author
|
@nosolosw all the suggestions were implemented, thanks! |
oandregal
approved these changes
Mar 26, 2019
Member
oandregal
left a comment
oandregal
left a comment
There was a problem hiding this comment.
I've pushed some fixes and all examples are now fully functioning. Let's have this 🚢
Member
|
Great work, for better or worse we have both |
Member
|
@chrisvanpatten have been your changes addressed? I think we can't merge until you either clear the "requested changes" status or give a 👍 (at least I don't see the option). |
4 tasks
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the block tutorial in Gutenberg Handbook to match the Gutenberg Examples repo.
I cleaned up a few other minor changes, and small fixes.
Fixes #14005
Fixes WordPress/gutenberg-examples#20
Types of changes
Documentation.