Skip to content

Image Block: Adding an edit image button for the image and cover image blocks #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowriad merged 2 commits into from
Jun 27, 2017
Merged

Image Block: Adding an edit image button for the image and cover image blocks #1459

youknowriad merged 2 commits into from
Jun 27, 2017

Conversation

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Jun 26, 2017 •
edited
Loading

closes #1412

  • Adding a "value" prop for the MediaUploadButton component
  • Adding the edit image control to the cover image and image blocks.
  • Storing the image id in the image block metadata (same for cover)
  • Dropping unused focus prop from the Toolbar component

@youknowriad youknowriad added the [Feature] Blocks Overall functionality of blocks label Jun 26, 2017
@youknowriad youknowriad self-assigned this Jun 26, 2017
@youknowriad youknowriad requested review from jasmussen and mtias June 26, 2017 15:48
@jasmussen
Copy link
Contributor

jasmussen commented Jun 27, 2017

Nice!

Right now it uses this icon:

screen shot 2017-06-27 at 09 50 05

Let's use this icon instead, and outside of that, 👍 👍

screen shot 2017-06-27 at 09 50 20

@youknowriad youknowriad merged commit 7e743f6 into master Jun 27, 2017
@youknowriad youknowriad deleted the update/allow-edit-image branch June 27, 2017 09:07
This was referenced Jun 27, 2017
Merged
Closed
@afercia afercia mentioned this pull request Jul 3, 2017
Closed
@aduth aduth mentioned this pull request Oct 27, 2017
Merged
dratwas pushed a commit that referenced this pull request Nov 14, 2019
@cameronvoell
Merge pull request #1459 from wordpress-mobile/master
35d25d3 
v1.15.0 Master -> Develop
This was referenced Sep 16, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtias mtias Awaiting requested review from mtias

@jasmussen jasmussen Awaiting requested review from jasmussen

Assignees

@youknowriad youknowriad

Labels

[Feature] Blocks Overall functionality of blocks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Photo Block has no "edit" button to re-open the media library modal

3 participants

@youknowriad @jasmussen