Skip to content

Updated the "Move to Trash" button #14591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gziolo merged 2 commits into from
Mar 26, 2019
Merged

Updated the "Move to Trash" button #14591

gziolo merged 2 commits into from
Mar 26, 2019

Conversation

@mapk
Copy link
Contributor

@mapk mapk commented Mar 23, 2019 •
edited by gziolo
Loading

Description

The "Move to trash" button in the document inspector wasn't title case. This PR makes the text match the title case of other buttons. Closes #12366.

How has this been tested?

Tested locally.

Screen Shot 2019-03-22 at 9 37 29 PM

Types of changes

Simple text change.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@mapk mapk self-assigned this Mar 23, 2019
@mapk mapk requested a review from karmatosed March 23, 2019 04:43
@mapk mapk mentioned this pull request Mar 23, 2019
Closed
gziolo
gziolo approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update Set featured image as well:

Screen Shot 2019-03-25 at 08 17 06
Screen Shot 2019-03-25 at 08 18 48

@gziolo gziolo added [Type] Copy Issues or PRs that need copy editing assistance General Interface Parts of the UI which don't fall neatly under other labels. labels Mar 25, 2019
@mapk mapk removed the [Type] Copy Issues or PRs that need copy editing assistance label Mar 25, 2019
@mapk
Copy link
Contributor Author

mapk commented Mar 25, 2019

I've updated not only the Set Featured Image button, but also the Remove Image and Replace Image buttons.

@gziolo
Copy link
Member

gziolo commented Mar 26, 2019

Nice, thanks for fixing all of them 🚢

@gziolo gziolo added this to the 5.4 (Gutenberg) milestone Mar 26, 2019
@gziolo gziolo merged commit 57c2ab3 into master Mar 26, 2019
@gziolo gziolo deleted the update/trash-button branch March 26, 2019 07:16
@Soean Soean mentioned this pull request Mar 30, 2019
Closed
This was referenced Apr 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo approved these changes

@karmatosed karmatosed Awaiting requested review from karmatosed

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@mapk mapk

Labels

General Interface Parts of the UI which don't fall neatly under other labels.

Projects

None yet

Milestone

5.4 (Gutenberg)

Development

Successfully merging this pull request may close these issues.

3 participants

@mapk @gziolo