Skip to content

Fix react warning for instanceId prop on a DOM element (<Button> component) #14599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nerrad merged 7 commits into from
Mar 25, 2019
Merged

Fix react warning for instanceId prop on a DOM element (<Button> component) #14599

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f8ec240
omit `instanceId` prop if it exists on dom leaf
nerrad Mar 24, 2019
51c5946
update changelog
nerrad Mar 24, 2019
6d94b99
revert unnecessary fix
nerrad Mar 25, 2019
0677392
remove unnecessary uage of HOC
nerrad Mar 25, 2019
07dd2be
update changelog
nerrad Mar 25, 2019
b25cbe8
update out-of-date snapshots
nerrad Mar 25, 2019
382f0ed
add missing header tags
nerrad Mar 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
7.2.1 (Unreleased)
Copy link
Contributor

@youknowriad youknowriad Mar 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is missing some ## :)


### Bug fixes

- Fix `instanceId` prop passed through to `Button` component via `MenuItems` producing React console error. [#14599](https://github.com/WordPress/gutenberg/pull/14599)

## 7.2.0 (2019-03-20)

### Improvements
Expand Down
7 changes: 6 additions & 1 deletion packages/components/src/button/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
* External dependencies
*/
import classnames from 'classnames';
import { omit } from 'lodash';

/**
* WordPress dependencies
Expand Down Expand Up @@ -42,9 +43,13 @@ export function Button( props, ref ) {
const tag = href !== undefined && ! disabled ? 'a' : 'button';
const tagProps = tag === 'a' ? { href, target } : { type: 'button', disabled };

const passThruProps = additionalProps.instanceId ?
omit( additionalProps, [ 'instanceId' ] ) :
additionalProps;

return createElement( tag, {
...tagProps,
...additionalProps,
...passThruProps,
className: classes,
ref,
} );
Expand Down