Fix undefined drop-cap class #1468
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when adding a new text block, it gets a
drop-cap-undefinedclass becausedropCapis not defined in the block (instead ofdrop-cap-falseI guess). If the drop cap toggle is turned on, there will be adrop-cap-trueclass.It makes more sense to only add a
drop-capclass if it's enabled and don't do anything else otherwise. You can target non-drop-cap blocks using the:not()CSS selector already.Plus,
drop-capis more readable thandrop-cap-falseanddrop-cap-true.