Data: Avoid assuming persisted preferences shape #14692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
requested review from
ajitbohra,
ellatrix,
gziolo,
jorgefilipecosta and
talldan
as code owners
gziolo
added
[Type] Enhancement
gziolo
approved these changes
Mar 29, 2019
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
This looks great. Thanks for doing an extensive audit of existing selectors 💯
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #14580, #14691
This pull request seeks to update references to persisted preferences objects to avoid assumed shape of individual property values within preferences. See #14580 for additional context.
Testing instructions:
Verify unit tests pass:
Extra credit: Verify no regressions in affected behavior (insert usage, feature activation, active sidebar, NUX dismissed tips).