Update TextControl design documentation #14710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davewhitley
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
noisysocks,
talldan and
youknowriad
as code owners
davewhitley
added
[Type] Developer Documentation
To align with the formatting of other READMEs.
kjellr
approved these changes
Mar 29, 2019
Contributor
kjellr
left a comment
kjellr
left a comment
There was a problem hiding this comment.
Looks great, @drw158! I made a couple very minor fixes/markdown edits, but this is good to go. 👍
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial commit to update TextControl readme. These changes add design documentation.
Description
This PR adds design guideline documentation in addition to the development documentation that existed previously. These guidelines are 'best practices' for the usage of the component, as well as describing the component in more detail.
Screenshots
A preview can be seen here, although it doesn't represent what it will look like in the handbook:
preview
Feedback
I'd appreciate feedback on:
Thank you!