Skip to content

Conversation

@gziolo
Copy link
Member

@gziolo gziolo commented Apr 2, 2019

Description

This PR is a follow-up for #14551 which introduced a way to inline block.json metadata.

Scope covered by this PR:

  • all static blocks (no PHP files) use block.json files for the following fields:
    • name
    • category
    • attributes

There were 2 exceptions where I couldn't easily move attributes to JSON file:

I opened separate PRs for them: #14862 and #14863.

How has this been tested?

npm run test

npm run dev and ensure all blocks work as before.

@gziolo gziolo added [Type] Task Issues or PRs that have been broken down into an individual action to take [Package] Block library /packages/block-library [Feature] Block Directory Related to the Block Directory, a repository of block plugins labels Apr 2, 2019
@gziolo gziolo self-assigned this Apr 2, 2019
@gziolo gziolo force-pushed the update/block-json-static branch from 9fe927f to 73424ca Compare April 2, 2019 14:48
@gziolo gziolo marked this pull request as ready for review April 2, 2019 15:29
@gziolo gziolo requested a review from tellyworth April 2, 2019 15:29
@gziolo gziolo force-pushed the update/block-json-static branch from 73424ca to 565618e Compare April 3, 2019 08:01
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this iterative approach. I left a few questions. I also saw that you didn't move the file block attributes because of the i18n issue, we should try the solution discussed in #core-js here.

@gziolo
Copy link
Member Author

gziolo commented Apr 3, 2019

I like this iterative approach. I left a few questions. I also saw that you didn't move the file block attributes because of the i18n issue, we should try the solution discussed in #core-js here.

Yes, Tabel and File blocks have some challenges which I plan to resolve later this week.

Update: File block is being addressed in #14862. Table block is being addressed in #14863.

@gziolo gziolo force-pushed the update/block-json-static branch 4 times, most recently from 7616373 to 45723df Compare April 5, 2019 15:47
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's iterate 👍

@Soean Soean mentioned this pull request Apr 9, 2019
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Block Directory Related to the Block Directory, a repository of block plugins [Package] Block library /packages/block-library [Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants