Fixes #1472: Block mover isn't clickable #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When block goes behind an image that is left aligned, the image block covers block mover buttons so we can't move the block.
youknowriad
reviewed
Jun 27, 2017
editor/block-mover/style.scss
Outdated
| left: 0; | ||
| padding: 0 14px 20px 0; // handles hover area | ||
|
|
||
| z-index: 100; |
Contributor
There was a problem hiding this comment.
Works great 👍 but we should probably use our z-index mixin. https://github.com/WordPress/gutenberg/blob/master/editor/assets/stylesheets/_z-index.scss#L16
Contributor
Author
There was a problem hiding this comment.
Should I create new z-layer or use one of exists value?
Contributor
There was a problem hiding this comment.
You should create a new one and give it the .editor-block-mover name
Contributor
Author
There was a problem hiding this comment.
Thank you. I have just updated the PR.
mtias
added
[Type] Bug
youknowriad
approved these changes
Jun 27, 2017
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Great! Thanks for the fix
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When block goes behind an image that is left aligned, the image block covers block mover buttons so we can't move the block.