Skip to content

UI Components: Refactor BlockSettingsMenu and MoreMenu as DropdownMenu #14843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gziolo merged 18 commits into from
Jun 3, 2019
Merged

UI Components: Refactor BlockSettingsMenu and MoreMenu as DropdownMenu #14843

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9dc5a86
Components: Document missing menuLabel, position, className Dropdown …
aduth Apr 5, 2019
e01d053
Components: Add render prop support to DropdownMenu
aduth Apr 5, 2019
eb321f9
Block Editor: Refactor BlockSettingsMenu as DropdownMenu
aduth Apr 5, 2019
e262c3f
CHANGELOG 7a54cec63
aduth Apr 5, 2019
635e7f4
CHANGELOG 743e4da7c
aduth Apr 5, 2019
68dd8f5
CHANGELOG ea8265827
aduth Apr 5, 2019
e557b60
Components: Remove unintended tabs from DropdownMenu tests
aduth Apr 5, 2019
51acab9
Refactor MoreMenu component to use DropdownMenu component
gziolo Apr 12, 2019
2d34643
Use single label for DrowdownMenu components
gziolo Apr 15, 2019
cf462a6
Fix all failing e2e tests
gziolo Apr 15, 2019
7ea821b
Add all class names for backward compatibility
gziolo Apr 15, 2019
dc93e96
Fix unit tests by refreshing saved snapshots
gziolo Apr 15, 2019
4864809
Update packages/components/src/menu-group/index.js
aduth Apr 18, 2019
67a4f8b
Add back removed changelog update for components during rebase
gziolo May 14, 2019
6276b9c
Mark all props used with DropdownMenu for backward compatibility as u…
gziolo May 14, 2019
2456dde
Remove obsolete DropdownMenuSepararator component
gziolo May 28, 2019
1b24803
Apply changes after rebase to align CSS styles with master
gziolo May 30, 2019
032167a
Display dropdown menu indicator only when icon set expliclity to false
gziolo May 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Components: Document missing menuLabel, position, className Dropdown … 
…props
  • Loading branch information
@aduth @gziolo
aduth authored and gziolo committed May 30, 2019
commit 9dc5a8609f7d5483a9a399c1900d860f99299357
22 changes: 22 additions & 0 deletions packages/components/src/dropdown-menu/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,21 @@ A human-readable label to present as accessibility text on the focused collapsed
- Type: `String`
- Required: Yes

#### menuLabel

A human-readable label to present as accessibility text on the expanded menu container.

- Type: `String`
- Required: No

#### position

The direction in which the menu should open. Specify y- and x-axis as a space-separated string. Supports `"top"`, `"middle"`, `"bottom"` y axis, and `"left"`, `"center"`, `"right"` x axis.

- Type: `String`
- Required: No
- Default: `"top center"`

#### controls

An array of objects describing the options to be shown in the expanded menu.
Expand All @@ -122,3 +137,10 @@ Each object should include an `icon` [Dashicon](https://developer.wordpress.org/
- Required: Yes

See also: [https://developer.wordpress.org/resource/dashicons/](https://developer.wordpress.org/resource/dashicons/)

#### className

A class name to apply to the dropdown wrapper element.

- Type: `String`
- Required: No