[Mobile] Fix title not focusing #15069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the post title is not being focused when the user tap on it.
Related
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#893I noticed that the:
Is necessary for the ListBlock to get focus properly, but the addition of it broke the PostTitle, since context.onFocus is undefined when setting up the PostTitle's RichText component.
To solve it, we pass the
onFocusfrom ownProps directly ifcontext.onFocusis undefined.I'd prefer to give
context.onFocuspreference, since it's how it is supposed to be set up for blocks, being the PostTitle the special case (the one that needsownProps.onFocus).The difference with Web is that they don't use
RichTextfor the PostTitle.To test: