Skip to content

Conversation

@kjellr
Copy link
Contributor

@kjellr kjellr commented Apr 22, 2019

#14145 introduced a new left-side placement for the block breadcrumb. This worked great at first, but when #15022 reintroduced the block movers for wide and full blocks, we realized that the new breadcrumb location overlapped with the block movers.

This PR is a potential fix for the overlap: it moves the block breadcrumb down slightly for full/wide blocks when the block movers are visible. It bumps right up against the block content itself, but I don't think this should actually cause any issues.

Before:

Screen Shot 2019-04-22 at 2 14 53 PM

After:

Screen Shot 2019-04-22 at 2 15 40 PM

movers-after

@kjellr kjellr added Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor labels Apr 22, 2019
@kjellr kjellr requested a review from jasmussen April 22, 2019 18:19
@kjellr kjellr requested a review from chrisvanpatten as a code owner April 22, 2019 18:19
@kjellr kjellr self-assigned this Apr 22, 2019
@jasmussen
Copy link
Contributor

Yep, good solution. 👍 👍

I don't see the jumpiness that shows up in your GIFs on my end, though — which is good, that jumpiness is a little weird.

Here's what I see. Master:

master

This branch:

this branch

Both of those are cool to me.


I think we should keep thinking about what to do with these hover labels, separately. Do we need them? Do they become tooltips? (Think hovering an img with a title on the web.)

Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks need to pass.

@kjellr
Copy link
Contributor Author

kjellr commented Apr 23, 2019

Thanks for the review! I'll merge in once that test is complete. I agree, it may be worth removing the block breadcrumbs entirely. I'm not convinced they're needed anymore.

I don't see the jumpiness that shows up in your GIFs on my end, though — which is good, that jumpiness is a little weird.

Tha only shows up under a really specific circumstance: if you hover over the center-to-right area of a block, activate the block breadcrumb, and then move your mouse over to the left of the block to trigger the appearance of the block movers. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Design Feedback Needs general design feedback. [Package] Block editor /packages/block-editor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants