Skip to content

Conversation

@jorgefilipecosta
Copy link
Member

Description

Server-side rendered blocks are not being correctly parsed on widgets screen making legacy widget blocks not load correctly on #15074.
The problem was that the server side block definitions were not being bootstrapped on the widgets page.

How has this been tested?

I went to the widgets page http://yah.local/wp-admin/admin.php?page=gutenberg-widgets.
I pasted wp.blocks.parse('<!-- wp:latest-posts {"postsToShow":34,"displayPostDate":true} /-->');on the developer tools command line.
I verified the attributes were correctly parsed on the return value.

@jorgefilipecosta jorgefilipecosta added [Type] Bug An existing feature does not function as intended [Feature] Widgets Screen The block-based screen that replaced widgets.php. labels May 3, 2019
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@jorgefilipecosta jorgefilipecosta merged commit a90752e into master May 6, 2019
@jorgefilipecosta jorgefilipecosta deleted the fix/server-side-rendered-blocks-not-parsed-on-the-widgets-screen branch May 6, 2019 14:03
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants