Skip to content

Port blockquote block to RN mobile #15482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergioEstevao merged 18 commits into from
May 24, 2019
Merged

Port blockquote block to RN mobile #15482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6f02cba
Enable quote block in editor.
SergioEstevao Apr 30, 2019
8dc7c06
Add mobile version of quote edit.
SergioEstevao Apr 30, 2019
116cf9b
Merge branch 'master' into rnmobile/blockquote_port_to_mobile
SergioEstevao May 15, 2019
ae65dfc
Stop reading focus from context.
SergioEstevao May 15, 2019
3bc05ac
Make default tag to be div like on the web.
SergioEstevao May 22, 2019
6507230
Implement block quote component in web and RN.
SergioEstevao May 22, 2019
4d1de79
Simplify native block quote component.
SergioEstevao May 22, 2019
f5ebb76
Implement empty Alignment toolbar.
SergioEstevao May 22, 2019
536442e
Merge branch 'master' into rnmobile/blockquote_port_to_mobile
SergioEstevao May 22, 2019
587a01b
Merge branch 'master' into rnmobile/blockquote_port_to_mobile
SergioEstevao May 23, 2019
03be5ad
Fix style import.
SergioEstevao May 23, 2019
f28f013
Remove import
SergioEstevao May 23, 2019
a1a16f4
Rename blockquote to BlockQuotation.
SergioEstevao May 24, 2019
08b2327
Move BlockQuotation to be a primate component.
SergioEstevao May 24, 2019
d8b77ba
Add documentation reference for BlockQuotation.
SergioEstevao May 24, 2019
1f8a12a
Add BlockQuotation info to the changeling.
SergioEstevao May 24, 2019
1f2e231
Update packages/components/CHANGELOG.md
SergioEstevao May 24, 2019
889116f
Restore style file.
SergioEstevao May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move BlockQuotation to be a primate component.
  • Loading branch information
@SergioEstevao
SergioEstevao committed May 24, 2019
commit 08b232792d1832b6f448ea5bac3cc36af3d27144
5 changes: 1 addition & 4 deletions packages/block-library/src/quote/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,7 @@
*/
import { __ } from '@wordpress/i18n';
import { AlignmentToolbar, BlockControls, RichText } from '@wordpress/block-editor';
/**
* Internal dependencies
*/
import { BlockQuotation } from './blockquotation';
import { BlockQuotation } from '@wordpress/components';
Copy link
Contributor

@youknowriad youknowriad May 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should gather all these Platform specific components in a separate package or otherwise under the same parent variable.

Whether it's import { Blockquote, Div } from '@wordpress/platform'

or

import { PlatformComponents } from '@wordpress/components';
const { Blockquote, Div } = PlatformComponents;

Copy link
Member

@gziolo gziolo May 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is a good point. I think we should extract all those components into their own package and maybe re-export from @wordpress/components for backward compatibility only. It's definitely out of the scope of this PR @SergioEstevao. Anyway, it's something we should decide on quite soon as you will need to use more HTML tags like:

  • figure, img
  • ul, ol, li
  • div


export default function QuoteEdit( { attributes, setAttributes, isSelected, mergeBlocks, onReplace, className } ) {
const { align, value, citation } = attributes;
Expand Down
15 changes: 15 additions & 0 deletions packages/components/src/primitives/block-quotation/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# HorizontalRule

A drop-in replacement for the HTML [blockquote](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/blockquote) element that works both on the web and in the mobile apps. It indicates that the enclosed text is an extended quotation.

## Usage

```jsx
import { BlockQuotation } from '@wordpress/components';

const MyBlockQuotation = () => (
<BlockQuotation>
...Quote content
</BlockQuotation>
);
```
0 ...block-library/src/quote/blockquotation.js → ...s/src/primitives/block-quotation/index.js
View file
Open in desktop
File renamed without changes.
0 ...ibrary/src/quote/blockquotation.native.js → ...rimitives/block-quotation/index.native.js
View file
Open in desktop
File renamed without changes.
0 ...block-library/src/quote/style.native.scss → ...mitives/block-quotation/style.native.scss
View file
Open in desktop
File renamed without changes.
0 packages/block-library/src/quote/style.scss → ...src/primitives/block-quotation/style.scss
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions packages/components/src/primitives/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
export * from './svg';
export * from './horizontal-rule';
export * from './block-quotation';