Skip to content

Registers the core/group Block as the default block for handling "grouping" interactions #15774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 7 commits into from
Jun 19, 2019
Merged

Registers the core/group Block as the default block for handling "grouping" interactions #15774

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0cefdb2
Adds grouping interaction to state
getdave May 22, 2019
984c695
Registers grouping block
getdave May 22, 2019
0460751
Auto updated README
getdave May 22, 2019
7a9380e
Adds test for get/set Grouping block
getdave Jun 5, 2019
c4aa491
Update documentation with clearer descriptions
getdave Jun 17, 2019
39c6408
Adds reducer and selector tests
getdave Jun 17, 2019
be17c02
Updates “Blog” for correct “Block” in docs
getdave Jun 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Registers grouping block
  • Loading branch information
@getdave
getdave committed Jun 5, 2019
commit 984c695514a668be2c207d19dc3f30f055956d10
5 changes: 5 additions & 0 deletions packages/block-library/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
setDefaultBlockName,
setFreeformContentHandlerName,
setUnregisteredTypeHandlerName,
setGroupingBlockName,
unstable__bootstrapServerSideBlockDefinitions, // eslint-disable-line camelcase
} from '@wordpress/blocks';

Expand Down Expand Up @@ -135,4 +136,8 @@ export const registerCoreBlocks = () => {
setFreeformContentHandlerName( classic.name );
}
setUnregisteredTypeHandlerName( missing.name );

if ( group ) {
Copy link
Member

@aduth aduth Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When would this not be true?

Copy link
Contributor

@mcsf mcsf Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was browsing the file and came to ask the same thing. :) @getdave

Copy link
Member

@aduth aduth May 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request at #22563

setGroupingBlockName( group.name );
}
};