proxied getEditorSettings in block-editor #15807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
requested review from
ellatrix,
gziolo,
talldan and
youknowriad
as code owners
youknowriad
reviewed
May 24, 2019
youknowriad
reviewed
May 24, 2019
packages/block-editor/src/components/block-settings-menu/block-mode-toggle.js
Outdated
Show resolved
Hide resolved
youknowriad
reviewed
May 24, 2019
youknowriad
approved these changes
May 24, 2019
Contributor
youknowriad
left a comment
youknowriad
left a comment
There was a problem hiding this comment.
Small comment pending but Thanks for the fix 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #14932 was merged the block editor got coupled with the editor. This PR removes the coupling following @youknowriad 's suggestion by proxying the getEditorSettings from editor into block-editor:
Link to original issue
How has this been tested?
Tested locally, the original behaviour which introduced the problem is unchanged after the decoupling.