Re-enable the menu item hover state on small screens #16168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjellr
added
[Type] Enhancement
kjellr
requested review from
aduth,
ajitbohra,
chrisvanpatten,
gziolo,
jorgefilipecosta,
talldan and
youknowriad
as code owners
afercia
approved these changes
Jun 14, 2019
Contributor
afercia
left a comment
afercia
left a comment
There was a problem hiding this comment.
From an accessibility perspective, LGTM. Thank you!
mapk
approved these changes
Jun 14, 2019
Contributor
mapk
left a comment
mapk
left a comment
There was a problem hiding this comment.
I just tested. It works good from a design perspective.
Contributor
Author
|
Thanks, all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12262. Reverses a change made in #10333.
As discussed in #12262 (comment), this PR turns on the menu-item hover state for all breakpoints.
There should be no visible difference from
masterif a touch-enabled user presses on a menu item, but unlikemaster, the hover states will be activated if that user presses them and scrolls the viewport. This isn't ideal, but but as discussed in #12262, this may be an okay tradeoff. If we merge this, we may want to reopen #10320 to keep tracking this issue.GIF: