Skip to content

Support Navigation and Edit Mode #16500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 29 commits into from
Aug 2, 2019
Merged

Support Navigation and Edit Mode #16500

Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
69dc40d
Support Navigation and Edit Mode
youknowriad Jul 10, 2019
56c1f4e
Support removing blocks from navigation mode
youknowriad Jul 10, 2019
df415d5
Add is-navigation className
youknowriad Jul 10, 2019
fc8510a
Style adjustments
kjellr Jul 10, 2019
fe42bc2
Update API docs
youknowriad Jul 10, 2019
e3db2a5
Fix e2e tests by moving to edit mode
youknowriad Jul 10, 2019
1af2e64
alt+f10 only works on edit mode
youknowriad Jul 10, 2019
494bec0
Use blue highlight color all around.
kjellr Jul 11, 2019
58e51f9
no hover styles and breadcrumbs on hover in navigation mode
youknowriad Jul 11, 2019
836a6e5
Fix image navigation mode
youknowriad Jul 15, 2019
6662db5
Trigger the edit mode on mouse down instead of move
youknowriad Jul 18, 2019
c9469e6
Fix the edit mode trigger in e2e tests
youknowriad Jul 18, 2019
e11c08d
Correct breadcrumb size and text position.
kjellr Jul 19, 2019
680c254
Rename the is-navigate-mode className and fix the docs
youknowriad Jul 24, 2019
1ee2661
Fix typo
youknowriad Jul 24, 2019
439c30f
Better param documentation
youknowriad Jul 24, 2019
1903f3d
Fix typo
youknowriad Jul 24, 2019
21cb1ad
Fix typo
youknowriad Jul 24, 2019
4eb1cf2
Simplify the arrow navigation code
youknowriad Jul 24, 2019
3af2e23
Fix ESCAPE behavior
youknowriad Jul 24, 2019
ad94bd7
Fix e2e test edit mode utility
youknowriad Jul 26, 2019
fcae4c1
Simplify applied classname
youknowriad Jul 29, 2019
4de1964
Update packages/e2e-test-utils/src/keyboard-mode.js
youknowriad Jul 29, 2019
226a8c8
Use a boolean instead of a string for the keyboard mode
youknowriad Jul 29, 2019
039efc0
Adding comment
youknowriad Jul 29, 2019
e75a720
Fix e2e tests
youknowriad Jul 29, 2019
5400dcf
More consistency in the naming of the navigation mode actions/functions
youknowriad Aug 2, 2019
aae87af
Limit the edit mode trigger to the writing flow component
youknowriad Aug 2, 2019
fbfbe6c
Consistently disable navigation mode in e2e tests
youknowriad Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the edit mode trigger in e2e tests
  • Loading branch information
@youknowriad
youknowriad committed Jul 26, 2019
commit c9469e6cf2e8d631b3b185851d1b90f36ced3266
3 changes: 1 addition & 2 deletions packages/e2e-test-utils/src/keyboard-mode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@
* @return {Promise} Promise resolving after enabling the keyboard edit mode.
*/
export async function switchToEditMode() {
await page.mouse.move( 0, 0 );
await page.mouse.move( 10, 10 );
await page.click( '.edit-post-layout__content' );
}