Slimmer top/bottom spacing inside notices

[kjellr]

Currently, our Notice component ships with 1em of padding on the top and bottom of the content area:

This results in a lot of extra room on the top and bottom of the text:

This PR changes that spacing to $grid-size-small, to balance it out with the spacing on the sides, and to align to our standard spacing increments, instead of 1em:

[aduth]

Code-wise this looks good, and I agree the padding is both too much and inconsistent with the rest of the admin.

I was curious where the original values might have come from, and I note that the rest of the admin uses a total of 1em margin for paragraphs in a notice:

https://github.com/WordPress/wordpress-develop/blob/master/src/wp-admin/css/common.css#L1388

I don't know if we care to mimic this, or if it's necessary to adjust other style values here (there's default padding on the notice itself, in addition to the margin of the content).)

[chrisvanpatten]

This has been bugging me for a while but I've been too busy to fix it, so I'm very happy to see this PR! Thanks @kjellr!

[youknowriad]

I knew there was some back and forth here. It looks like this breaks the alignment of the "close" button in the regular notices of the editor.

Try

wp.data.dispatch('core/notices').createNotice(
		'info',
		'Post published.', // Text string to display.
		{
			isDismissible: true, // Whether the user can dismiss the notice.
			// Any actions the user can perform.
            actions: [
				{
					onClick: () => console.log( 'test' ),
					label: 'View post'
				}
			]
		}
	);

[kjellr]

@youknowriad good catch. I pushed a new change that sets the top/bottom margins to $grid-size when they're inside of the components-notice-list. This keeps that close button in the right space, and also ensures that notices up there are a bit taller than the Sidebar's tabbed nav area (I remember this being a concern before, since we don't want the notices to be interpreted as an extension of that bar):

[youknowriad]

Thanks for the fix

[chrisvanpatten]

Looks great! 🚢

[kjellr]

Thanks everyone!